Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add aliquot sum of a number algorithm, class Math #2400

Merged
merged 16 commits into from
Jan 22, 2023
Merged

feat: Add aliquot sum of a number algorithm, class Math #2400

merged 16 commits into from
Jan 22, 2023

Conversation

SpiderMath
Copy link
Contributor

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Opened this PR since I closed #2250 by mistake 😦 Sorry for the trouble 😔

@SpiderMath SpiderMath mentioned this pull request Nov 26, 2022
Closed
8 tasks
@SpiderMath
Copy link
Contributor Author

@Panquesito7 Might wanna check this out, I've been sitting on this PR for a while now, since #2250 😶 🥺

@Panquesito7 Panquesito7 added the enhancement New feature or request label Nov 30, 2022
Panquesito7
Panquesito7 requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/SpiderMath/C-Plus-Plus_TheAlgorithms/actions

@Panquesito7 Panquesito7 added the requested changes changes required label Nov 30, 2022
@SpiderMath
Copy link
Contributor Author

SpiderMath commented Dec 5, 2022 •
edited
Loading

Great work! rocket Please enable GitHub Actions in your repository of this fork in this link: https://github.com/SpiderMath/C-Plus-Plus_TheAlgorithms/actions

Well, the windows compile checks seem to be failing but not due to any code of mine apparently, going by the error messages (this is from before merging the latest stuff in master to this fork)

@SpiderMath
Copy link
Contributor Author

@Panquesito7 (>.<)

@SpiderMath
Copy link
Contributor Author

@Panquesito7 hey 😬

@SpiderMath

This comment was marked as outdated.

Sign in to view
@SpiderMath
Copy link
Contributor Author

@Panquesito7 (._.)
Man, atleast reply

Panquesito7
Panquesito7 approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Thank you. 🚀

@Panquesito7 Panquesito7 removed the requested changes changes required label Dec 28, 2022
@SpiderMath
Copy link
Contributor Author

SpiderMath commented Jan 2, 2023 •
edited
Loading

That took months to approve 💀

@Panquesito7 Panquesito7 merged commit 249ba88 into TheAlgorithms:master Jan 22, 2023
@Panquesito7 Panquesito7 mentioned this pull request Jan 31, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgurwara99 tjgurwara99 tjgurwara99 approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpiderMath @tjgurwara99 @Panquesito7