Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added log code for counting digits #2234

Merged
merged 19 commits into from
Apr 14, 2023
Merged

added log code for counting digits #2234

merged 19 commits into from
Apr 14, 2023

Conversation

futoid
Copy link
Contributor

@futoid futoid commented Oct 12, 2022 •
edited
Loading

Description of Change

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Added constant time code to count the number of digits

@futoid
Copy link
Contributor Author

futoid commented Oct 13, 2022

Hey @Panquesito7 Can you verify and tell if any changes required?

@Panquesito7 Panquesito7 added enhancement New feature or request Improvement improvement in previously written codes and removed enhancement New feature or request labels Nov 29, 2022
tjgurwara99
tjgurwara99 previously approved these changes Jan 3, 2023
View reviewed changes
Panquesito7
Panquesito7 requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the clang-tidy warnings.
Let us know if you need any help with that. Thanks. 🙂

futoid

This comment was marked as resolved.

Sign in to view

Panquesito7
Panquesito7 reviewed Jan 30, 2023
View reviewed changes
math/finding_number_of_digits_in_a_number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_digits_in_a_number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_digits_in_a_number.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added the automated tests are failing Do not merge until tests pass label Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Mar 2, 2023
@futoid
Copy link
Contributor Author

futoid commented Mar 3, 2023

cland-tidy for this
Possible solutions that I found: making narrowing conversion intentionally.

Kindly assist with this @Panquesito7

@Panquesito7 Panquesito7 removed the stale Author has not responded to the comments for over 2 weeks label Mar 3, 2023
@Panquesito7
Copy link
Member

Let's discuss this on the Discord community, so that other members can help as well. 🙂

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Apr 3, 2023
@Panquesito7 Panquesito7 removed automated tests are failing Do not merge until tests pass stale Author has not responded to the comments for over 2 weeks labels Apr 7, 2023
Panquesito7
Panquesito7 previously approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thanks! 🚀

realstealthninja
realstealthninja previously approved these changes Apr 9, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Panquesito7 Panquesito7 merged commit fddbf08 into TheAlgorithms:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnacx krishnacx krishnacx left review comments

@tjgurwara99 tjgurwara99 tjgurwara99 approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@realstealthninja realstealthninja realstealthninja left review comments

Assignees
No one assigned
Labels
Improvement improvement in previously written codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@futoid @Panquesito7 @tjgurwara99 @realstealthninja @krishnacx