Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : add modular_inverse_simple #1937

Merged
merged 23 commits into from
Jun 9, 2022
Merged

feat : add modular_inverse_simple #1937

merged 23 commits into from
Jun 9, 2022

Conversation

CarlosZoft
Copy link
Member

@CarlosZoft CarlosZoft commented Feb 15, 2022 •
edited by gitpod-io bot
Loading

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

this is a simple implementation made during a college course - discrete mathematics

Panquesito7
Panquesito7 requested changes Feb 15, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

math/modular_inverse_simple.cpp Outdated Show resolved Hide resolved
math/modular_inverse_simple.cpp Outdated Show resolved Hide resolved
math/modular_inverse_simple.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added enhancement New feature or request requested changes changes required labels Feb 15, 2022
@CarlosZoft
Copy link
Member Author

thanks for review

tjgurwara99
tjgurwara99 previously approved these changes Feb 27, 2022
View reviewed changes
Copy link
Member

@tjgurwara99 tjgurwara99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Apr 16, 2022
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Apr 24, 2022
@CarlosZoft
Copy link
Member Author

@poyea can you review this pr?

@poyea poyea reopened this Apr 24, 2022
@poyea poyea self-assigned this Apr 24, 2022
@poyea poyea requested review from Panquesito7 and removed request for Panquesito7 April 24, 2022 16:09
poyea
poyea previously approved these changes Apr 24, 2022
View reviewed changes
poyea
poyea previously approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Apr 25, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label May 25, 2022
@CarlosZoft
Copy link
Member Author

:(

@poyea poyea requested review from Panquesito7 and removed request for Panquesito7 May 25, 2022 19:14
@poyea
Copy link
Member

poyea commented May 25, 2022

@CarlosZoft You need approval from @Panquesito7

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label May 26, 2022
@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes required labels Jun 9, 2022
Panquesito7
Panquesito7 reviewed Jun 9, 2022
View reviewed changes
math/modular_inverse_simple.cpp Outdated Show resolved Hide resolved
math/modular_inverse_simple.cpp Outdated Show resolved Hide resolved
math/modular_inverse_simple.cpp Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 previously approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much for your work 🚀 Sorry for the delay!

@Panquesito7 Panquesito7 merged commit 274cab6 into TheAlgorithms:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgurwara99 tjgurwara99 tjgurwara99 left review comments

@poyea poyea poyea left review comments

@Panquesito7 Panquesito7 Panquesito7 left review comments

Assignees

@poyea poyea

Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CarlosZoft @poyea @tjgurwara99 @Panquesito7