Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Union of two arrays #1794

Merged
merged 23 commits into from
Oct 24, 2021
Merged

fix: Union of two arrays #1794

merged 23 commits into from
Oct 24, 2021

Conversation

alvinphilips
Copy link
Contributor

@alvinphilips alvinphilips commented Oct 23, 2021 •
edited by gitpod-io bot
Loading

Description of Change

I used int64_t in place of int32_t while iterating through the elements of the array. I fixed it and that is the only change.

Checklist

  • Added description of change
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Small issue, fixed it

alvinphilips and others added 23 commits October 19, 2021 05:31
@alvinphilips
Create reverse_binary_tree.cpp
c760166
@alvinphilips
Added documentation
cbad183 
Added Documentation for the level_order_traversal() function, and implemented a print() function to display the tree to STDOUT
@alvinphilips
Added documentation
54143f2
@alvinphilips
Renamed tests to test
41af1e4
@alvinphilips
Fixed issue with incorrect using statement
fb86292
updating DIRECTORY.md
6c5794a
clang-format and clang-tidy fixes for fb86292
e9cd4fd
@alvinphilips
Added Test cases
b222cb2
@alvinphilips
Merge branch 'binary-tree' of https://github.com/polarvoid/C-Plus-Plus …
ffbbc65 
…into binary-tree
@alvinphilips
Merge branch 'master' into master
2208192
@alvinphilips @Panquesito7
Update operations_on_datastructures/reverse_binary_tree.cpp
0421f55 
Co-authored-by: David Leal <[email protected]>
@alvinphilips @Panquesito7
Update operations_on_datastructures/reverse_binary_tree.cpp
657f759 
Co-authored-by: David Leal <[email protected]>
@alvinphilips @Panquesito7
Update operations_on_datastructures/reverse_binary_tree.cpp
aabd5a2 
Co-authored-by: David Leal <[email protected]>
@alvinphilips @Panquesito7
Update operations_on_datastructures/reverse_binary_tree.cpp
ff091f7 
Co-authored-by: David Leal <[email protected]>
@alvinphilips @Panquesito7
Update operations_on_datastructures/reverse_binary_tree.cpp
76255dd 
Co-authored-by: David Leal <[email protected]>
@alvinphilips
Changed int to int64_t
14a26c3
@alvinphilips
Updated documentation wording
39bb9b9
@alvinphilips
Merge branch 'TheAlgorithms:master' into master
46936a7
@alvinphilips
Merge branch 'TheAlgorithms:master' into master
1ade0de
@alvinphilips
Merge branch 'TheAlgorithms:master' into master
eb32bf7
@alvinphilips
Fixed wrong integer type
3954ceb 
Changed int64_t to int32_t
@alvinphilips
Merge branch 'master' into union-of-two-arrays
2af706b
clang-format and clang-tidy fixes for 2af706b
972a520
@Panquesito7 Panquesito7 added the enhancement New feature or request label Oct 24, 2021
Panquesito7
Panquesito7 approved these changes Oct 24, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@Panquesito7 Panquesito7 merged commit 51e1dda into TheAlgorithms:master Oct 24, 2021
@alvinphilips
Copy link
Contributor Author

Thanks! 😄

@alvinphilips alvinphilips deleted the union-of-two-arrays branch October 24, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvinphilips @Panquesito7