New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added integral approximation algorithm #1485

Merged

ayaankhan98 merged 36 commits into TheAlgorithms:master from bwalton24:master

Apr 22, 2021

Contributor

bwalton24 commented Apr 20, 2021

Description of Change

Algorithm that takes in a lower bound, upper bound, function, and an optional delta value and computes an integral approximation.

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes:

bwalton24 and others added 10 commits

April 6, 2021 13:55


          Setup general integral aprroximation algorithm template

553e0a1


          feat: added integral approximation algorithm

86b98c9


          updating DIRECTORY.md

e67546f


          feat: added integral approximation algorithm

88a457c


          Merge branch 'master' of https://github.com/TheAlgorithms/C-Plus-Plus

ee12066


          test: added tests for integral approximation algorithm

432795c


          docs: added comments and explanation for integral approximation algor…

d26f108

…ithm


          fix: updated for loop within algorithm

ab22dc6


          fix: data type conversions

d26784b


          Modified dividing by 2

a78c238

Maintains functionality but dividing by 2 is easier to read/understand

Panquesito7 added the enhancement label

Panquesito7 requested changes

View reviewed changes

Member

Panquesito7 left a comment

👍 Good work.

math/integral_approximation.cpp Outdated

@@ @@ -0,0 +1,111 @@ @@
+              /**
+               * @file
+               * @brief Algorithm to compute integral approximation of function

Member

Panquesito7 Apr 21, 2021

Provide a Wikipedia link in Markdown format (if available/possible).
If there's no Wikipedia link, add another web source for algorithm explanation.

Also, add a detailed/long description of the algorithm (use @details for this).

math/integral_approximation.cpp Outdated

Comment on lines 8 to 11

+              #include <cassert>
+              #include <cmath>
+              #include <functional>
+              #include <iostream>

Member

Panquesito7 Apr 21, 2021

Add a one-line description of what the library/header is for (see the example below).

#include <cassert>    /// for assert
#include <iostream>  /// for IO operations

math/integral_approximation.cpp Outdated Show resolved Hide resolved

math/integral_approximation.cpp Outdated Show resolved Hide resolved

math/integral_approximation.cpp Outdated Show resolved Hide resolved

math/integral_approximation.cpp Outdated Show resolved Hide resolved

math/integral_approximation.cpp Outdated Show resolved Hide resolved

math/integral_approximation.cpp Outdated Show resolved Hide resolved

math/integral_approximation.cpp Outdated Show resolved Hide resolved

math/integral_approximation.cpp Outdated Show resolved Hide resolved

Panquesito7 added the requested changes label

shiqisheng2036 and others added 3 commits

April 21, 2021 13:30


          Update math/integral_approximation.cpp

59247fd

Co-authored-by: David Leal <[email protected]>


          Update math/integral_approximation.cpp

109a26a

Co-authored-by: David Leal <[email protected]>


          Update math/integral_approximation.cpp

23c9cfc

Co-authored-by: David Leal <[email protected]>

github-actions bot force-pushed the master branch 2 times, most recently from 081c080 to 23c9cfc Compare

April 21, 2021 19:33


          Update math/integral_approximation.cpp

8ed70fc

Co-authored-by: David Leal <[email protected]>

github-actions bot force-pushed the master branch from 79dbaff to 8ed70fc Compare

April 21, 2021 19:34

shiqisheng2036 and others added 3 commits

April 21, 2021 13:34


          Update math/integral_approximation.cpp

973be1d

Co-authored-by: David Leal <[email protected]>


          fix: Apply suggestions from code review

233f04d


          fix: Apply suggestions from code review

3a53020

github-actions bot force-pushed the master branch 2 times, most recently from 0d90265 to 3a53020 Compare

April 21, 2021 19:43

Panquesito7 added 3 commits

April 21, 2021 14:43


          fix: Apply suggestions from code review

354c7e9


          fix: Apply suggestions from code review

b305d0f


          fix: Apply suggestions from code review

d6ac9ce

github-actions bot force-pushed the master branch 2 times, most recently from c8816aa to d6ac9ce Compare

April 21, 2021 19:45

Panquesito7 added 2 commits

April 21, 2021 14:48


          fix: Apply suggestions from code review

9ee83ba


          fix: Apply suggestions from code review

ae5c2a8

Panquesito7 reviewed

View reviewed changes

math/integral_approximation.cpp Show resolved Hide resolved


          feat: added Wikipedia link and detailed description

7e09f2c

github-actions bot force-pushed the master branch from c2eb8f8 to 7e09f2c Compare

April 21, 2021 19:52


          fix: Apply suggestions from code review

46dc993

shiqisheng2036 approved these changes

View reviewed changes

shiqisheng2036 previously approved these changes

View reviewed changes

Panquesito7 requested changes

View reviewed changes

math/integral_approximation.cpp Outdated Show resolved Hide resolved

math/integral_approximation.cpp Outdated Show resolved Hide resolved

math/integral_approximation.cpp Outdated Show resolved Hide resolved

shiqisheng2036 dismissed their stale review via

3b659d9

April 21, 2021 20:17

shiqisheng2036 and others added 3 commits

April 21, 2021 14:17


          Update math/integral_approximation.cpp

3b659d9

Co-authored-by: David Leal <[email protected]>


          Update math/integral_approximation.cpp

4816da9

Co-authored-by: David Leal <[email protected]>


          Update math/integral_approximation.cpp

6a09e7f

Co-authored-by: David Leal <[email protected]>

github-actions bot force-pushed the master branch 2 times, most recently from 95219b7 to 6a09e7f Compare

April 21, 2021 20:18

Panquesito7 requested changes

View reviewed changes

Member

Panquesito7 left a comment

Please address all the unresolved conversations above.


          style: updated what the library/header is for

2102e70

Panquesito7 reviewed

View reviewed changes

math/integral_approximation.cpp Outdated Show resolved Hide resolved


          docs: Update math/integral_approximation.cpp

afc6c7e

Co-authored-by: David Leal <[email protected]>

Panquesito7 reviewed

View reviewed changes

math/integral_approximation.cpp Outdated

+                                     const std::function<double(double)>& func,
+                                     double delta = .0001) {
+                  double result = 0;
+                  int numDeltas = static_cast<int>((ub - lb) / delta);

Member

Panquesito7 Apr 21, 2021

Consider using uint64_t for non-negative values (or their appropriate size: uint32_t, uint16_t, uint8_t) or int64_t for negative values. Check other parts of the code (reference).

shiqisheng2036 added 2 commits

April 21, 2021 16:57


          fix: changed int to uint64_t


          Merge branch 'master' of https://github.com/bwalton24/C-Plus-Plus

1fe52a3

Panquesito7 reviewed

View reviewed changes

math/integral_approximation.cpp Outdated Show resolved Hide resolved


          Update math/integral_approximation.cpp

ae714a4

Co-authored-by: David Leal <[email protected]>

Panquesito7 approved these changes

View reviewed changes

Member

Panquesito7 left a comment

Nice work; your code is neat. Thank you for your contribution! 👍 🎉

Panquesito7 added approved and removed requested changes labels

Panquesito7 requested a review from ayaankhan98

April 22, 2021 00:40

ayaankhan98 approved these changes

View reviewed changes

Member

ayaankhan98 left a comment

LGTM! Thanks for your contribution @bwalton24

ayaankhan98 merged commit a41b707 into TheAlgorithms:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved enhancement