Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tree): tree 组件修改为 composition api #837

Merged
merged 54 commits into from
Nov 25, 2022

Conversation

TabSpace
Copy link
Collaborator

@TabSpace TabSpace commented May 5, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

tree 组件重构为 composition api

💡 需求背景和解决方案

📝 更新日志

  • refactor(tree): tree 组件重构为 composition api

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • ☑️ 文档已补充或无须补充
  • ☑️ 代码演示已提供或无须提供
  • ☑️ TypeScript 定义已补充或无须补充
  • ☑️ Changelog 已提供或无须提供

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #837 (bf7a612) into develop (492d477) will increase coverage by 3.68%.
The diff coverage is 80.46%.

@@             Coverage Diff             @@
##           develop     #837      +/-   ##
===========================================
+ Coverage    57.94%   61.62%   +3.68%     
===========================================
  Files          407      643     +236     
  Lines        15371    15741     +370     
  Branches      2931     2817     -114     
===========================================
+ Hits          8907     9701     +794     
+ Misses        6187     5749     -438     
- Partials       277      291      +14     
Impacted Files Coverage Δ
src/alert/_example/icon.vue 100.00% <ø> (ø)
src/alert/_usage/index.vue 0.00% <ø> (ø)
src/anchor/_usage/index.vue 0.00% <ø> (ø)
src/avatar/_example/base.vue 100.00% <ø> (ø)
src/avatar/_usage/index.vue 0.00% <ø> (ø)
src/badge/_usage/index.vue 0.00% <ø> (ø)
src/breadcrumb/_example/custom.vue 100.00% <ø> (ø)
src/breadcrumb/_example/dropdown.vue 100.00% <ø> (ø)
src/button/_example/icon.vue 100.00% <ø> (ø)
src/button/_usage/index.vue 0.00% <ø> (ø)
... and 458 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

完成

@PengYYYYY
Copy link
Collaborator

这个PR是不是要提到 https://github.com/Tencent/tdesign-vue-next/pulls 这边来

@github-actions
Copy link
Contributor

这个 PR 已经过时了,因为它已经持续 45 天没有任何活动了。 删除 stale 的标签或评论,否则将在 10 天内关闭。

@github-actions github-actions bot added the Stale label Jun 20, 2022
@uyarn uyarn removed Stale labels Jun 30, 2022
@github-actions
Copy link
Contributor

这个 PR 已经过时了,因为它已经持续 45 天没有任何活动了。 删除 stale 的标签或评论,否则将在 10 天内关闭。

@github-actions github-actions bot added the Stale label Aug 15, 2022
@github-actions github-actions bot removed the Stale label Aug 18, 2022
@uyarn
Copy link
Collaborator

uyarn commented Nov 16, 2022

@TabSpace tab哥 这期间其他开发者还迭代了拖拽的能力 还需要把这部分重构加进来

@TabSpace
Copy link
Collaborator Author

@TabSpace tab哥 这期间其他开发者还迭代了拖拽的能力 还需要把这部分重构加进来

看了下,区别太大,没办法直接合并进来。我先清理覆盖了,然后再重新添加拖动能力吧。

@chaishi
Copy link
Collaborator

chaishi commented Nov 25, 2022

非拖拽树,需要加一下判空

image

@chaishi chaishi merged commit 5bcd087 into Tencent:develop Nov 25, 2022
This was referenced Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants