Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timepicker): prevent scroll after closing panel #1590

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Sep 30, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(TimePicker): 关闭面板不再滚动 避免部分场景滚动未结束关闭面板继续滚动引发的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

完成

@codecov-commenter
Copy link

Codecov Report

Merging #1590 (dd26fee) into develop (492d477) will increase coverage by 4.35%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1590      +/-   ##
===========================================
+ Coverage    57.94%   62.29%   +4.35%     
===========================================
  Files          407      677     +270     
  Lines        15371    16174     +803     
  Branches      2931     2815     -116     
===========================================
+ Hits          8907    10076    +1169     
+ Misses        6187     5802     -385     
- Partials       277      296      +19     
Impacted Files Coverage Δ
src/range-input/range-input-popup-props.ts 25.00% <0.00%> (-75.00%) ⬇️
src/grid/row-props.ts 71.42% <0.00%> (-28.58%) ⬇️
src/select/util.ts 65.00% <0.00%> (-26.67%) ⬇️
src/date-picker/props.ts 43.75% <0.00%> (-26.25%) ⬇️
src/select/props.ts 54.54% <0.00%> (-20.46%) ⬇️
src/date-picker/date-range-picker-props.ts 35.29% <0.00%> (-19.26%) ⬇️
src/affix/affix.tsx 22.72% <0.00%> (-16.34%) ⬇️
src/upload/props.ts 58.33% <0.00%> (-13.10%) ⬇️
src/select/optionGroup.tsx 31.57% <0.00%> (-9.60%) ⬇️
src/cascader/props.ts 55.55% <0.00%> (-8.74%) ⬇️
... and 474 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xiaosansiji xiaosansiji merged commit 89cd5ee into develop Oct 8, 2022
@xiaosansiji xiaosansiji deleted the fix/timepicker branch October 8, 2022 03:11
@github-actions github-actions bot mentioned this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants