Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Input和Collapse组件增加节点类名 #1530

Merged
merged 7 commits into from
Sep 20, 2022
Merged

feat: Input和Collapse组件增加节点类名 #1530

merged 7 commits into from
Sep 20, 2022

Conversation

huangpiqiao
Copy link
Contributor

@huangpiqiao huangpiqiao commented Sep 19, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  • 问题1:Input组件聚焦时,父级节点无法通过类变化监听到从而修改样式
    解决方案:聚焦时在父级添加t-input__wrapper--focused类

  • 问题2:Collapse-panel组件的header内容直接渲染,没有父级包裹,在做ie兼容时无法针对对应的部分编写样式
    解决方案:在header中添加left、content、right三个父级盒子包裹左、中、右的内容

📝 更新日志

  • fear(Collapse): 增加节点和类名处理IE样式

  • fix(InputNumber): 处理0比较的异常 #common850

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

完成

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #1530 (4095b3b) into develop (492d477) will increase coverage by 4.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1530      +/-   ##
===========================================
+ Coverage    57.94%   61.95%   +4.00%     
===========================================
  Files          407      655     +248     
  Lines        15371    15838     +467     
  Branches      2931     2826     -105     
===========================================
+ Hits          8907     9812     +905     
+ Misses        6187     5735     -452     
- Partials       277      291      +14     
Impacted Files Coverage Δ
src/range-input/range-input-popup-props.ts 25.00% <0.00%> (-75.00%) ⬇️
src/grid/row-props.ts 71.42% <0.00%> (-28.58%) ⬇️
src/select/util.ts 65.00% <0.00%> (-26.67%) ⬇️
src/select/props.ts 54.54% <0.00%> (-20.46%) ⬇️
src/date-picker/props.ts 53.84% <0.00%> (-16.16%) ⬇️
src/date-picker/date-range-picker-props.ts 42.85% <0.00%> (-11.69%) ⬇️
src/select/optionGroup.tsx 31.57% <0.00%> (-9.60%) ⬇️
src/cascader/props.ts 55.55% <0.00%> (-8.74%) ⬇️
src/upload/dragger.tsx 27.27% <0.00%> (-7.51%) ⬇️
src/cascader/cascader.tsx 56.89% <0.00%> (-7.11%) ⬇️
... and 441 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/input/input.tsx Outdated Show resolved Hide resolved
@uyarn
Copy link
Collaborator

uyarn commented Sep 20, 2022

image

没有垂直居中

@uyarn uyarn changed the title Input和Collapse组件优化 feat: Input和Collapse组件增加节点类名 Sep 20, 2022
@uyarn uyarn merged commit f814588 into Tencent:develop Sep 20, 2022
@github-actions github-actions bot mentioned this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants