Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config-provider): support classprefix replace for all components #1287

Merged
merged 4 commits into from
Aug 16, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Aug 14, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  • 在ConfigProvider的mixins中新增componentNameclassPrefixcommonSizeClassNamecommonStatusClassName
  • 新增classPrefixMixins 用于没有全局配置属性的组件获取componentNameclassPrefixcommonSizeClassNamecommonStatusClassName
  • 删除部分组件中通过写死的 prefix构造的CLASSNAME

📝 更新日志

  • feat(ConfigProvider): 支持通过ConfigProvider修改全部组件的classPrefix

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2022

完成

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2022

Codecov Report

Merging #1287 (008a18f) into develop (492d477) will increase coverage by 0.05%.
The diff coverage is 66.13%.

@@             Coverage Diff             @@
##           develop    #1287      +/-   ##
===========================================
+ Coverage    57.94%   58.00%   +0.05%     
===========================================
  Files          407      408       +1     
  Lines        15371    15291      -80     
  Branches      2931     2898      -33     
===========================================
- Hits          8907     8869      -38     
+ Misses        6187     6147      -40     
+ Partials       277      275       -2     
Impacted Files Coverage Δ
src/calendar/const.ts 100.00% <ø> (ø)
src/cascader/cascader.tsx 64.00% <ø> (ø)
src/color-picker/color-picker.tsx 81.25% <ø> (ø)
src/date-picker/DatePicker.tsx 26.74% <ø> (ø)
src/date-picker/DateRangePicker.tsx 15.43% <0.00%> (-0.40%) ⬇️
src/date-picker/base/Header.tsx 7.57% <0.00%> (-0.37%) ⬇️
src/date-picker/date-picker-panel-props.ts 100.00% <ø> (+90.00%) ⬆️
src/date-picker/date-range-picker-panel-props.ts 100.00% <ø> (+90.90%) ⬆️
src/date-picker/date-range-picker-props.ts 42.85% <0.00%> (-11.69%) ⬇️
src/date-picker/hooks/useRange.ts 35.89% <ø> (ø)
... and 140 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@uyarn uyarn force-pushed the feat/classprefix branch 3 times, most recently from 3a68242 to 5ab14b1 Compare August 15, 2022 06:51
@uyarn uyarn changed the title feat(configprovider): support classprefix replace for all components feat(config-provider): support classprefix replace for all components Aug 15, 2022
@xiaosansiji xiaosansiji merged commit d61937b into develop Aug 16, 2022
@xiaosansiji xiaosansiji deleted the feat/classprefix branch August 16, 2022 03:00
@github-actions github-actions bot mentioned this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants