Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): 修复部分情况可能导致监听事件未移除,keys透传问题 #1184

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

skytt
Copy link
Contributor

@skytt skytt commented Jul 18, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

完成

@codecov-commenter
Copy link

Codecov Report

Merging #1184 (24f62ff) into develop (aaf0135) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop    #1184      +/-   ##
===========================================
- Coverage    58.80%   58.80%   -0.01%     
===========================================
  Files          405      405              
  Lines        15051    15053       +2     
  Branches      2844     2845       +1     
===========================================
+ Hits          8851     8852       +1     
- Misses        5927     5928       +1     
  Partials       273      273              
Impacted Files Coverage Δ
src/table/hooks/tree-store.ts 10.39% <ø> (ø)
src/select/select.tsx 41.62% <75.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d171ff4...24f62ff. Read the comment docs.

@uyarn uyarn merged commit 912136e into Tencent:develop Jul 18, 2022
This was referenced Jul 18, 2022
@skytt skytt deleted the fix/select-keys-and-event-listener branch July 18, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants