Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix iOS minimum version,when used Vukan 1.2 #2621

Merged
merged 2 commits into from
Feb 1, 2021
Merged

fix iOS minimum version,when used Vukan 1.2 #2621

merged 2 commits into from
Feb 1, 2021

Conversation

DaChengTechnology
Copy link
Contributor

fix iOS minimum version,when used Vukan 1.2

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #2621 (5a3012e) into master (4cd1a5c) will decrease coverage by 14.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2621       +/-   ##
===========================================
- Coverage   87.63%   73.34%   -14.30%     
===========================================
  Files         478      101      -377     
  Lines       92114    12712    -79402     
===========================================
- Hits        80722     9323    -71399     
+ Misses      11392     3389     -8003     
Impacted Files Coverage Δ
src/layer/dequantize.cpp 0.00% <0.00%> (-46.38%) ⬇️
src/layer/requantize.cpp 0.00% <0.00%> (-43.96%) ⬇️
src/mat.cpp 69.49% <0.00%> (-10.13%) ⬇️
src/mat.h 83.38% <0.00%> (-7.08%) ⬇️
src/layer/crop.cpp 77.02% <0.00%> (-5.62%) ⬇️
src/allocator.cpp 70.79% <0.00%> (-5.51%) ⬇️
src/mat_pixel.cpp 53.42% <0.00%> (-2.73%) ⬇️
src/cpu.cpp 56.21% <0.00%> (-2.13%) ⬇️
src/layer/padding.cpp 68.13% <0.00%> (-2.05%) ⬇️
src/layer/cast.cpp 82.89% <0.00%> (-1.06%) ⬇️
... and 454 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cd1a5c...5a3012e. Read the comment docs.

@nihui
Copy link
Member

nihui commented Feb 1, 2021

We will increase ios minimal deployment target version to 9.0 unconditionally

@DaChengTechnology
Copy link
Contributor Author

Update IOS mininum version to 9.0

@nihui nihui merged commit 11d1de7 into Tencent:master Feb 1, 2021
@nihui
Copy link
Member

nihui commented Feb 1, 2021

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants