Skip to content

Commit

Permalink
Always install system_ext manifest.
Browse files Browse the repository at this point in the history
Add a default system_ext manifest so that it is always installed
even when SYSTEM_EXT_MANIFEST_FILES are not defined.

Bug: 137712494
Test: m check-vintf-all -j

Change-Id: I0d2c967ff3f3d0b64c71f7b3dec7aef5a422ea8c
Merged-In: I0d2c967ff3f3d0b64c71f7b3dec7aef5a422ea8c
  • Loading branch information
Yifan Hong committed Mar 21, 2020
1 parent 05d0c03 commit dc0cec9
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 10 deletions.
24 changes: 14 additions & 10 deletions vintfdata/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,14 @@ LOCAL_PATH := $(call my-dir)
# the module. It is recommended that such device-specific modules to be
# installed on product partition.

FRAMEWORK_MANIFEST_INPUT_FILES := $(LOCAL_PATH)/manifest.xml
SYSTEM_MANIFEST_INPUT_FILES := $(LOCAL_PATH)/manifest.xml
ifdef DEVICE_FRAMEWORK_MANIFEST_FILE
FRAMEWORK_MANIFEST_INPUT_FILES += $(DEVICE_FRAMEWORK_MANIFEST_FILE)
SYSTEM_MANIFEST_INPUT_FILES += $(DEVICE_FRAMEWORK_MANIFEST_FILE)
endif

SYSTEM_EXT_MANIFEST_INPUT_FILES := $(LOCAL_PATH)/system_ext_manifest.default.xml
ifdef SYSTEM_EXT_MANIFEST_FILES
SYSTEM_EXT_MANIFEST_INPUT_FILES += $(SYSTEM_EXT_MANIFEST_FILES)
endif

ifeq ($(BOARD_IS_AUTOMOTIVE), true)
Expand Down Expand Up @@ -75,12 +80,12 @@ LOCAL_MODULE_PATH := $(TARGET_OUT)/etc/vintf
GEN := $(local-generated-sources-dir)/manifest.xml

$(GEN): PRIVATE_VINTF_VNDK_VERSION := $(VINTF_VNDK_VERSION)
$(GEN): PRIVATE_FRAMEWORK_MANIFEST_INPUT_FILES := $(FRAMEWORK_MANIFEST_INPUT_FILES)
$(GEN): $(FRAMEWORK_MANIFEST_INPUT_FILES) $(HOST_OUT_EXECUTABLES)/assemble_vintf
$(GEN): PRIVATE_SYSTEM_MANIFEST_INPUT_FILES := $(SYSTEM_MANIFEST_INPUT_FILES)
$(GEN): $(SYSTEM_MANIFEST_INPUT_FILES) $(HOST_OUT_EXECUTABLES)/assemble_vintf
PROVIDED_VNDK_VERSIONS="$(PRIVATE_VINTF_VNDK_VERSION) $(PRODUCT_EXTRA_VNDK_VERSIONS)" \
PLATFORM_SYSTEMSDK_VERSIONS="$(PLATFORM_SYSTEMSDK_VERSIONS)" \
$(HOST_OUT_EXECUTABLES)/assemble_vintf \
-i $(call normalize-path-list,$(PRIVATE_FRAMEWORK_MANIFEST_INPUT_FILES)) \
-i $(call normalize-path-list,$(PRIVATE_SYSTEM_MANIFEST_INPUT_FILES)) \
-o $@

LOCAL_PREBUILT_MODULE_FILE := $(GEN)
Expand All @@ -106,25 +111,24 @@ include $(BUILD_PREBUILT)
endif

# System_ext Manifest
ifneq ($(SYSTEM_EXT_MANIFEST_FILES),)
include $(CLEAR_VARS)
LOCAL_MODULE := system_ext_manifest.xml
LOCAL_MODULE_STEM := manifest.xml
LOCAL_MODULE_CLASS := ETC
LOCAL_SYSTEM_EXT_MODULE := true
LOCAL_MODULE_RELATIVE_PATH := vintf
GEN := $(local-generated-sources-dir)/manifest.xml
$(GEN): PRIVATE_SYSTEM_EXT_MANIFEST_FILES := $(SYSTEM_EXT_MANIFEST_FILES)
$(GEN): $(SYSTEM_EXT_MANIFEST_FILES) $(HOST_OUT_EXECUTABLES)/assemble_vintf
$(GEN): PRIVATE_SYSTEM_EXT_MANIFEST_FILES := $(SYSTEM_EXT_MANIFEST_INPUT_FILES)
$(GEN): $(SYSTEM_EXT_MANIFEST_INPUT_FILES) $(HOST_OUT_EXECUTABLES)/assemble_vintf
$(HOST_OUT_EXECUTABLES)/assemble_vintf \
-i $(call normalize-path-list,$(PRIVATE_SYSTEM_EXT_MANIFEST_FILES)) \
-o $@

LOCAL_PREBUILT_MODULE_FILE := $(GEN)
include $(BUILD_PREBUILT)
endif

VINTF_VNDK_VERSION :=
FRAMEWORK_MANIFEST_INPUT_FILES :=
SYSTEM_MANIFEST_INPUT_FILES :=
SYSTEM_EXT_MANIFEST_INPUT_FILES :=
DEVICE_MATRIX_INPUT_FILE :=
PRODUCT_MANIFEST_INPUT_FILES :=
2 changes: 2 additions & 0 deletions vintfdata/system_ext_manifest.default.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<manifest version="1.0" type="framework">
</manifest>

0 comments on commit dc0cec9

Please sign in to comment.