Add whitelist to only retrieve supported YouTube itags/streams #9748
Conversation
TobiGr
force-pushed
the
feat/av1-tags
branch
2 times, most recently
from
47d8cf4
to
6689ed9
Compare
TobiGr
changed the title
TobiGr
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
|
Great! This is service-dependent, isn't it? Though I doubt there is any way around this. |
|
oh yes, I could also add a condition to check the current service to make sure that there are no side effects. I did not test this PR with other services. |
AudricV
changed the title
NewPipe Extractor now extracts all YouTube Itags and therefore only those which can be handled by the player need to be retrieved from the list of all available streams.
|
Tested with the other services as well. I did not encounter any problems |
|
Kudos, SonarCloud Quality Gate passed! |
|
Shouldn't the filtering happen on a client level? What if NewPipe isn't able to play a specific video, while Piped is, or viceversa? |
You are correct. And for exactly that reason this PR is opened in the client / app repo and not the extractor repo :) |
There was a problem hiding this comment.
Sorry, I don't know why I thought we were on the extractor... Anyway, looks good to me. Note that we have getUrlAndNonTorrentStreams too, which is used for external players, and we might want to prevent/allow other kinds of streams from being opened in external streams, too.
What is it?
Description of the changes in your PR
This PR makes NewPipe compatible with the changes from TeamNewPipe/NewPipeExtractor#488 and TeamNewPipe/NewPipeExtractor#706
Relies on the following changes
TeamNewPipe/NewPipeExtractor#488 and TeamNewPipe/NewPipeExtractor#706 can, but do not have to be merged
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence