Remove the redundant/overlapping toast "Copied to clipboard" for Android 13+ #8961
Conversation
AudricV
added
feature request
|
@AudricV can you please review the PR |
|
In case if there is any issue please tell me , I will resolve it |
AudricV
removed
the
template ignored
|
@AudricV is this PR is ready to merge or i have to do some more modifications in this ? |
|
We already have a release candidate for the next version, so wait for it to be released. |
👍 |
There was a problem hiding this comment.
Thank you, there is no need here to use the full qualified name of the Android Build class, as this class can be imported without any conflicts (there is no other Build class used in the files modified).
Also, this class is already imported in the files modified by this PR.
@dhruvpatidar359 Could you apply these changes, please? Thank you in advance!
Edit: done myself
AudricV
changed the title
…oid 13+ Signed-off-by: dhruv <[email protected]> Co-authored-by: Tobi <[email protected]> Co-authored-by: AudricV <[email protected]>
…tead This method is not needed anymore, as ShareUtils.copyToClipboard does almost the same thing (no label is set on the ClipData used to copy text, contrary to what Utility did, but using "text" as a ClipData label doesn't seem useful). It was used in MissionAdapter.handlePopupItem to copy the SHA1 or the MD5 of a file.
|
Kudos, SonarCloud Quality Gate passed! |
What is it?
Description of the changes in your PR
This PR removes the extra toast when some text is copied using
ShareUtils.copyToClipboard, for Android 13 and above.The
copyToClipboardmethod of theUtilityclass has been removed and its usages have been replaced by the method ofShareUtils.Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence