Update AppCompat to 1.5.1 and compile SDK to 32 #8768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Isira-Seneviratne
force-pushed
the
AppCompat_1.5
branch
from
689ad17
to
15c195e
Compare
Isira-Seneviratne
force-pushed
the
AppCompat_1.5
branch
from
15c195e
to
68c48fa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
AudricV
changed the title
Isira-Seneviratne
force-pushed
the
AppCompat_1.5
branch
from
68c48fa
to
4b892e2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Nov 4, 2022
Merged
|
@Isira-Seneviratne How have you been able to merge this without an approving review? |
If I remember correctly, it was approved by @TobiGr . |
|
That could be true. If I remember correctly, I review this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence