Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong image used as a placeholder for channels avatars #8676

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Jul 22, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

In some places the "thumbnail" placeholder was being used instead of the "person" placeholder when loading a channel icon. Related: #8530.

Before/After Screenshots/Screen Record

Before After

Fixes the following issue(s)

Could not find any.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@triallax triallax added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Jul 22, 2022
@Stypox Stypox merged commit b2c2570 into TeamNewPipe:dev Jul 22, 2022
@Stypox Stypox changed the title Fix wrong thumbnail used as placeholder for channel Fix wrong image used as a placeholder for channels avatars Jul 22, 2022
@Stypox Stypox deleted the fix-channel-placeholders branch August 4, 2022 09:51
@Stypox Stypox mentioned this pull request Aug 27, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants