Remove unnecessary methods. #8663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
requested changes
Jul 20, 2022
| * @see #append(List items) | ||
| * @param items {@link PlayQueueItem}s to append | ||
| */ | ||
| public synchronized void append(@NonNull final PlayQueueItem... items) { |
There was a problem hiding this comment.
When this method was called with no arguments it meant that most code in append below did nothing except for broadcast(new AppendEvent(0));. I would rather create a new method called notifyChange() { broadcast(new AppendEvent(0)); } and call it in place of append(Collections.emptyList()); // Notify change
There was a problem hiding this comment.
I understand, I'll make the change tomorrow.
Isira-Seneviratne
force-pushed
the
Remove_unnecessary_methods
branch
from
c2bfcb5
to
6d1c614
Compare
triallax
added
the
codequality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence