Add Download entry to long-press menu

[notaLonelyDay]

What is it?

• Feature (user facing)

Description of the changes in your PR

Add option to download the video when long-pressing items.

Fixes the following issue(s)

• Fixes Direct download option in long press menu in info items #2171

Due diligence

• I read the contribution guidelines.

[notaLonelyDay]

This is my first issue at NewPipe and so I need some help from experienced maintainers

Firstly

To add download to long press menu, I have to create DownloadDialog, but to do this, I need StreamInfo, not StreamInfoItem
So I have to featch StreamInfo from StreamInfoItem, but to what disposable add .subscribe() result?
What is the best way to pass CompositeDisposable to StreamDialogDefaultEntry or maybe load it in some other place?

Secondly

While fetching, it is good to show some progress bar, where should it be shown? What is the best way to show progress in this case?

[SameenAhnaf]

it is good to show some progress bar, where should it be shown?

It should be discussed in #3332, I think.

[Stypox]

Thank you for the contribution!

So I have to featch StreamInfo from StreamInfoItem, but to what disposable add .subscribe() result?

Unfortunately currently Disposable are ignored in that class, because of bad design and other considerations. This is a known issue, see #7942 for more information. You don't have to solve it here.

While fetching, it is good to show some progress bar, where should it be shown? What is the best way to show progress in this case?

This is also currently not being done anywhere in the app (not even for e.g. "Open channel details" or "Start playing in the background") so here, too, you don't need to do anything.

It should be discussed in #3332, I think.

I don't think #3332 has anything to do with this: what @notaLonelyDay had a doubt about is showing a progress bar while loading the stream details, not showing progress for the download itself.

[notaLonelyDay]

Thanks for comments I'll do it as soon as I can

[notaLonelyDay]

@Stypox can you please merge?
Everything is done

[Stypox]

I made some changes myself. I tested (on API 19 and API 31) and it works. Sorry for the delay, we have been busy with the release and there have been other pending changes on the DownloadDialog for a while. Thank you!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Robbankz]

biggest newpipe addition of all time, i always wondered why i had to hit share and send to newpipe(myself) to download, although i dont agree with all your decisions e.g. bitchute, rumble etc etc, this is a good start, gotta give credit where credit is due