Refactor Player.useVideoSource logic and improve its comments #10195
+15
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
bug
TobiGr
approved these changes
Jun 29, 2023
- don't check for isAudioOnly == !videoEnabled, as this prevents enabling again video and text tracks renderers in some cases; - when reloading play queue manager if that's needed, disable or enable video and text tracks renderers, as they may need to be enabled again in some cases like starting a video in main player, opening play queue, switching to background player on it and switching back to main player; - disable or enable video renderers also for streams with AUDIO_STREAM StreamType, as doing so doesn't raise any issue and simplifies code; - reword and move some comments to make them easier to understand.
AudricV
force-pushed
the
player_refactor-renderers-activation-or-deactivation
branch
from
124f847
to
5ab3a4a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
I took a closer look and tested a bit more. I cannot think of anything that could go wrong by merging this. |
This was referenced Jul 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR simplifies the logic of the
useVideoSourcemethod of thePlayerclass and improves its comments. These changes should resolve the issues of video and text tracks renderers not enabling in some cases.Detailed version of the changes:
isAudioOnly == !videoEnabled, as this prevents enabling againvideo and text tracks renderers in some cases;
and text tracks renderers, as they may need to be enabled again in some cases
like starting a video in main player, opening play queue, switching to
background player on it and switching back to main player;
AUDIO_STREAMStreamType, as doing so doesn't raise any issue and simplifies code;Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Please test intensively these changes, by switching between multiple player types and streams of different services and testing every combination possible, to ensure that I introduced no regression.
Due diligence