Upgrade version of mypy

[zzz4zzz]

• Upgrade version of mypy
• Fix typing errors

[codecov-io]

Codecov Report

Merging #355 into master will increase coverage by <.01%.
The diff coverage is 99.16%.

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   97.32%   97.32%   +<.01%     
==========================================
  Files          49       49              
  Lines        3137     3138       +1     
  Branches      584      584              
==========================================
+ Hits         3053     3054       +1     
  Misses         44       44              
  Partials       40       40

Impacted Files	Coverage Δ
eli5/_graphviz.py	100% <100%> (ø)	⬆️
eli5/formatters/as_dict.py	95.83% <100%> (ø)	⬆️
eli5/base_utils.py	100% <100%> (ø)	⬆️
eli5/formatters/trees.py	100% <100%> (ø)	⬆️
eli5/sklearn_crfsuite/explain_weights.py	100% <100%> (ø)	⬆️
eli5/sklearn/unhashing.py	96.95% <100%> (ø)	⬆️
eli5/xgboost.py	99.39% <100%> (ø)	⬆️
eli5/formatters/html.py	100% <100%> (ø)	⬆️
eli5/utils.py	98.79% <100%> (ø)	⬆️
eli5/formatters/text_helpers.py	94.28% <100%> (ø)	⬆️
... and 26 more

[lopuhin]

Thanks for the PR @zzz4zzz , that's a nice upgrade to have. PR looks good to merge as-is, but maybe there are some improvements possible, could you please check the comments?

[zzz4zzz]

@lopuhin I've checked your comments and made fixes. Additionaly I've added --ignore-missing-imports to mypy command line and cleaned up imports.

[lopuhin]

Thanks @zzz4zzz , and --ignore-missing-imports is also a welcome addition. I'll check PR in more detail later today or tomorrow.

[Gallaecio]

The changes look good. However, after reading about the missing imports command-line option in https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports I think we should consider silencing on a library-by-library basis.

[lopuhin]

Looks great, thanks @zzz4zzz

However, after reading about the missing imports command-line option in https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports I think we should consider silencing on a library-by-library basis.

@Gallaecio good point, white-listing libraries looks like a good improvement to me 👍 But I'm also fine with merging this PR as-is, and leaving this improvement for future PRs.

[lopuhin]

Thanks for review @Gallaecio 👍