Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: activity result API 상수 -> 공통 enum class 리팩터링 #346

Merged
merged 5 commits into from
Sep 23, 2024
Merged

refactor: activity result API 상수 -> 공통 enum class 리팩터링 #346

merged 5 commits into from
Sep 23, 2024

Conversation

s9hn
Copy link
Member

@s9hn s9hn commented Sep 23, 2024 •
edited
Loading

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

  • Activity Result API 용 상수값 enum class화 했습니다.

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

  • 하나의 액티비티에서 여러 분기를 보내야하는 경우가 있어서 핵토파스칼 케이스로 'where+Description(optional)'로 적용했습니다.
  • ResultFrom은 import하고 액티비티명.Result_OK로 냅뒀는데 별로면 반박시 여러분 말맞추~
  • Activity를 붙이지 않은 이유는 Activity의 동반객체와 서로 import 충돌이 발생하기때문

@s9hn s9hn changed the title Feat/344 refactor: activity result API 상수 -> 공통 enum class 리팩터링 Sep 23, 2024
@s9hn s9hn self-assigned this Sep 23, 2024
@s9hn s9hn added ♻️ [REFACTOR] 기존 코드를 리팩토링합니다. ⚖️ 재상 세훈 전지적 세훈 시점 labels Sep 23, 2024
librarywon
librarywon approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@librarywon librarywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얌얌 맛도리 코드 감사합니다

junseo511
junseo511 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@junseo511 junseo511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

냠냠

app/src/main/java/com/teamwss/websoso/common/ui/model/ResultFrom.kt
CreateFeed,
;

val RESULT_OK: Int = ordinal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a: 오 ordinal 뭐임 신기하다

@s9hn s9hn merged commit 1bc53e2 into develop Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librarywon librarywon librarywon approved these changes

@junseo511 junseo511 junseo511 approved these changes

Assignees

@s9hn s9hn

Labels
♻️ [REFACTOR] 기존 코드를 리팩토링합니다. ⚖️ 재상 세훈 전지적 세훈 시점
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: activity result API 상수 -> 공통 enum class 리팩터링
3 participants
@s9hn @librarywon @junseo511