Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 쿠폰 상세 뷰 UI 개선 #194

Open
7 tasks done
nolanMinsung opened this issue Sep 21, 2024 · 0 comments · May be fixed by #198
Open
7 tasks done

[Fix] 쿠폰 상세 뷰 UI 개선 #194

nolanMinsung opened this issue Sep 21, 2024 · 0 comments · May be fixed by #198
Assignees
@nolanMinsung
Labels
Chore 🧩 자잘한 코드 수정 🧑🏻‍💻 민성 🧑🏻‍💻

Comments

@nolanMinsung
Copy link
Contributor

nolanMinsung commented Sep 21, 2024 •
edited
Loading

🔥 Issue 내용

쿠폰 상세 뷰의 UI를 개선할 부분이 있어 이를 반영하고자 합니다.

✅ To-do

  • 기존에 사용되던 팝업 뷰 제거
  • 쿠폰 안의 이미지 크기 & 위치 조정
  • 사용 방법 텍스트 적힌 라벨 수정
    • 높이 제약 해제
    • numberOfLines 2로 설정한 것 해제
    • setLineSpacing 메서드 사용 코드 삭제
  • 사용방법 텍스트 옆의 자물쇠&열쇠 이미지 크기 조정
  • 쿠폰 이미지 높이 설정 (iPhone 13 mini에서 세로로 길어 보이는 현상이 있음.
  • 각종 곡률반경 Figma 수치에 맞게 재조정
  • 점선 뷰 오른쪽 inset 적용되지 않는 문제 해결
@nolanMinsung nolanMinsung self-assigned this Sep 21, 2024
@nolanMinsung nolanMinsung changed the title [Chore] 쿠폰 상세 뷰 UI 개선 [Fix] 쿠폰 상세 뷰 UI 개선 Sep 21, 2024
nolanMinsung added a commit that referenced this issue Sep 22, 2024
@nolanMinsung
[Chore/#194] 사용 방법 관련 라벨 UI 수정
f0782f5
nolanMinsung added a commit that referenced this issue Sep 22, 2024
@nolanMinsung
[Chore/#194] 필요없는 코드(couponUsagePopupView) 삭제
83b5268
nolanMinsung added a commit that referenced this issue Sep 22, 2024
@nolanMinsung
[Chore/#194] 쿠폰 UI 개선 (이미지 크기 고정, inset 조정 등)
cbae47a
nolanMinsung added a commit that referenced this issue Sep 22, 2024
@nolanMinsung
[Merge/#194] branch 'main' into fix/#194
acf57da
nolanMinsung added a commit that referenced this issue Sep 22, 2024
@nolanMinsung
[Chore/#194] 쿠폰 점선 위치 및 두께 개선
b7e4234
nolanMinsung added a commit that referenced this issue Sep 22, 2024
@nolanMinsung
[Chore/#194] 필요없는 코드 삭제
6dec3ad
nolanMinsung added a commit that referenced this issue Sep 22, 2024
@nolanMinsung
[Del/#194] CouponCodeInputPopupView, CouponCodeInputPopupViewControll…
fbde3f9 
…er 삭제
@nolanMinsung nolanMinsung linked a pull request Sep 22, 2024 that will close this issue
Open
@nolanMinsung nolanMinsung linked a pull request Sep 22, 2024 that will close this issue
[Fix] #194 - 쿠폰 상세 뷰 UI 개선 #198
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nolanMinsung nolanMinsung

Labels
Chore 🧩 자잘한 코드 수정 🧑🏻‍💻 민성 🧑🏻‍💻
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] #194 - 쿠폰 상세 뷰 UI 개선 Team-Offroad/Offroad-iOS
1 participant
@nolanMinsung