Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2022-24125 and CVE-2022-24126 serverside fixes #127

Merged
merged 5 commits into from
Mar 19, 2022

Conversation

tremwil
Copy link
Contributor

@tremwil tremwil commented Mar 19, 2022

  • Fix CVE-2022-24125: Make sure RequestSendMessageToPlayers can only be used to send a PushRequestAllowBreakInTarget to a single player, which is what the game uses this request for.
  • Fix CVE-2022-24126: Validate insecure data that is transferred between clients (session join data in matchmaking requests, ghosts, bloodstains, messages, etc.). While session join data should now be fully safe, there may be other vulnerabilities present in ghosts, bloodstains and messages. Hence these should be disabled by default as they are not required for online play.

@TLeonardUK
Copy link
Owner

Looks good to me, there are a couple of stylistic changes I would prefer, but they aren't important enough to hold up the PR.

Thanks for the contribution William!

@TLeonardUK TLeonardUK merged commit 8bd051c into TLeonardUK:main Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants