Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tech category display names not getting applied #500

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Fixed tech category display names not getting applied #500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c31547
Fixed tech category display names not applied
Metious Nov 14, 2023
34b72b4
Cached variables
Metious Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Cached variables
  • Loading branch information
@Metious
Metious committed Nov 14, 2023
commit 34b72b4c14345db057baaae2ab2eda59017a902f
7 changes: 4 additions & 3 deletions Nautilus/Handlers/Enums/Extensions/EnumExtensions_TechCategory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,22 @@ public static EnumBuilder<TechCategory> WithPdaInfo(this EnumBuilder<TechCategor
{
var category = (TechCategory)builder;
var name = category.ToString();
var fullName = "TechCategory" + name;

if (!string.IsNullOrEmpty(displayName))
{
LanguageHandler.SetLanguageLine("TechCategory" + name, displayName, language);
LanguageHandler.SetLanguageLine(fullName, displayName, language);
uGUI_BlueprintsTab.techCategoryStrings.valueToString[category] = "TechCategory" + name;
return builder;
}

var friendlyName = Language.main.Get("TechCategory" + name);
var friendlyName = Language.main.Get(fullName);
if (string.IsNullOrEmpty(friendlyName))
{
InternalLogger.Warn($"Display name for TechCategory '{name}' is not specified and no language key has been found. Setting display name to 'TechCategory{name}'.");
}

uGUI_BlueprintsTab.techCategoryStrings.valueToString[category] = "TechCategory" + name;
uGUI_BlueprintsTab.techCategoryStrings.valueToString[category] = fullName;
return builder;
}

Expand Down
5 changes: 3 additions & 2 deletions Nautilus/Handlers/Enums/Extensions/EnumExtensions_TechGroup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@ public static EnumBuilder<TechGroup> WithPdaInfo(this EnumBuilder<TechGroup> bui
{
var techGroup = (TechGroup)builder;
var name = builder.ToString();
var fullName = "Group" + name;

if (!string.IsNullOrEmpty(displayName))
{
LanguageHandler.SetLanguageLine("Group" + name, displayName, language);
LanguageHandler.SetLanguageLine(fullName, displayName, language);
}
else if (string.IsNullOrEmpty(Language.main.Get("Group" + name)))
else if (string.IsNullOrEmpty(Language.main.Get(fullName)))
{
InternalLogger.Warn($"Display name was not specified and no existing language line has been found for TechGroup '{name}'.");
}
Expand Down