Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safety measures for localization registration #496

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Safety measures for localization registration #496

merged 1 commit into from
Nov 14, 2023

Conversation

Metious
Copy link
Member

@Metious Metious commented Nov 5, 2023

Changes made in this pull request

  • Added safety measures for localization registration to not accidentally try to deserialize non-json files.

MrPurple6411
MrPurple6411 approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@MrPurple6411 MrPurple6411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Metious Metious merged commit f4ec600 into SubnauticaModding:master Nov 14, 2023
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MrPurple6411 MrPurple6411 MrPurple6411 approved these changes

@LeeTwentyThree LeeTwentyThree Awaiting requested review from LeeTwentyThree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Metious @MrPurple6411