Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vehicle Upgrade Equipment Type Fixes #492

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Vehicle Upgrade Equipment Type Fixes #492

merged 3 commits into from
Oct 25, 2023

Conversation

Metious
Copy link
Member

@Metious Metious commented Oct 16, 2023

@Metious Metious self-assigned this Oct 16, 2023
@Metious Metious marked this pull request as ready for review October 16, 2023 19:04
@Metious
Better comparison for floats
0418e42 
Equality checks are very hard to meet for floats due to their precision points, therefore, approximation is always the better approach for comparing two floats.
MrPurple6411
MrPurple6411 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@MrPurple6411 MrPurple6411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Metious Metious merged commit 6bd3362 into SubnauticaModding:master Oct 25, 2023
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MrPurple6411 MrPurple6411 MrPurple6411 approved these changes

@LeeTwentyThree LeeTwentyThree Awaiting requested review from LeeTwentyThree

Assignees

@Metious Metious

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module gadgets don't work The Nautilus tutorial for modules has incorrect code
2 participants
@Metious @MrPurple6411