StoryGoal actions receive the name of the unlocked goal

[tinyhoot]

Changes made in this pull request

• Custom events for StoryGoals behave as the documentation claims and now receive the name of the calling goal as an argument. Fix for StoryGoal Custom Events do not receive name of triggering goal #475

Breaking changes

• None

[Metious]

As discussed in the issue, revert the breaking changes to the current methods, and just add two other overloads that only takes an Action<string>.

[tinyhoot]

Only an Action<string>? Without a key, any such method would receive the custom events of all other mods too.

[MrPurple6411]

Think these are the changes @Metious is meaning.

Hopefully he will clarify if I am off base.

[Metious]

Only an Action<string>? Without a key, any such method would receive the custom events of all other mods too.

Isn't that the point? Perhaps I'm simply not familiar with your use-case, but I think it's useless to assign a key while also taking the key as a parameter in the delegate.

If the method only takes an Action<string>, you should be able to handle multiple goals in the same method. This is also the closest implementation to the vanilla custom goals implementation, so it's fine for those delegates to be callbacked on every goal.

It's a feature, not a bug :)

[tinyhoot]

It's a feature, not a bug :)

That's a good point! I've incorporated both of your suggested changes into this. The documentation for the method which only takes an Action also no longer claims that a parameter will be passed.

Please let me know if there's anything else I can adjust.

[MrPurple6411]

hrmmm @Metious Do we want the keyhandlers to run before or after the regular ones.

[Metious]

Lgtm.