Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BZ ONLY] Added a better support for Hoverbike modules #429

Merged

Conversation

VELD-Dev
Copy link
Contributor

@VELD-Dev VELD-Dev commented Jul 2, 2023

Changes made in this pull request

  • Added a monobehaviour that is automatically added to the Hoverbike prefab on Hoverbike awake.
  • Added a few patches to fully handle the mono.
  • Added securities so the mono is always added to the Hoverbike mono.
  • I fixed the SeaTruck transpiler btw, it was not required so I just replaced with a postfix. It was crashing the VehicleUpgradesPatcher on BZ but it does not anymore now.
  • Tested module types and approved:
    • Instant modules
    • Chargeable modules
    • Selectable modules
    • SelectableChargeable modules
  • Toggleable modules might still be tried, but theoretically they work perfectly.
  • This time, I checked compatibility with vanilla modules, it's working perfectly.

Breaking changes

  • None.

VELD-Dev added a commit to VELD-Dev/Nautilus that referenced this pull request Jul 4, 2023
LeeTwentyThree added a commit that referenced this pull request Jul 4, 2023
* started working on a fix.

* Fixed the custom sounds handler.

A gigantic thanks to @Metious for researching the issues and the errors because I was too dumb and unexperienced with FMOD to do that, really !

Co-Authored-By: Metious <[email protected]>

* Added a new input in RegisterCustomSound, you can now give a MODE input in case you don't want to deal with AudioUtils.CreateSound(sound, MODE).
Added constant optimal Sound Modes to AudioUtils.
Based on what ROTA researches gave.

* safety removed, it will be patched with the fix in #429

* removed some debug logs

* Change MODE names to be more consistent

* Use stream mode by default for PDA voices

* Reference AudioUtils modes in XML docs

---------

Co-authored-by: Metious <[email protected]>
Co-authored-by: LeeTwentyThree <[email protected]>
@LeeTwentyThree LeeTwentyThree merged commit 7323b6b into SubnauticaModding:master Jul 4, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants