Allow multiple prefabs with same TechType #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not seem to cause any errors. |
EldritchCarMaker
approved these changes
Jun 2, 2023
|
|
||
| // If multiple prefabs sharing the same TechType are patched, only the first one will be spawnable by its TechType. | ||
| var techTypeString = info.TechType.AsString(); | ||
| if (!_techTypePrefabs.ContainsKey(techTypeString)) |
There was a problem hiding this comment.
I think this would be better as
_techTypePrefabs[info.TechType.AsString()] = info;
I think there could theoretically be a use case for actually replacing another prefab by using the same techtype. It's up to you if this is something we should encourage or not, though, as it is a fairly "hacky" thing to do.
|
This SHOULD NOT be a thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request