-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow controllers to use options menu #369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I have seen is great and what I can test works well, although I don't have a controller myself to try. Regarding the code, it seems like a harmless change with very little room for errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work, does leave a couple issues/feature requests open - mainly actually showing selection on tabs and the Clear implementation.
@celvro are those things you'd want to look into for it or just at a later time?
Also not a huge issue but to note: scrolling down it seems like we do invisibly select the headers but scrolling up it seems like we just immediately skip over the header |
…ers for console compatability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further controller improvements
Ok looks good! I also fixed ps4 icons, my controller was sending the wrong inputs but the icons looked correct for the buttons it was sending 🤷 Here's a list of known issues, I'm fine merging as is and fixing incrementally:
|
I'm helping a family member move today but can you just confirm whether 2 and 4 are completely Nautilus bugs or whether they happen in vanilla game/options menus too? |
Neither of them happen on vanilla but I don't think it has collapsible headers On 4 I tested with a second mod installed and it didn't skip over the last setting on that one. It still happened on the Nautilus option. Weird but imo it's not a big deal |
Approved with the caveat that we note down the issues and take another crack at figuring them out but they're pretty weird/abstract |
fixes #263, #289