Proper prefab cache #368
Merged
Proper prefab cache #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeTwentyThree
force-pushed
the
proper-prefab-cache
branch
from
afb5016
to
7095c34
Compare
|
Possible feature request for this issue: should there be an option for prefabs to not use the cache? I.e. the Gargantuan Leviathan which may be a lot to store in memory. |
|
I can confirm though that this increases performance drastically when spawning great numbers of modded prefabs. This change will help cut down on a lot of performance issues from mods such as De-Extinction. Edit: okay not really that big of a difference but it still feels more proper to do it this way... |
EldritchCarMaker
requested changes
May 27, 2023
EldritchCarMaker
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request
Resolves #364