Fixed Choice options not saving for ConfigFile instances #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJumpscare
approved these changes
May 23, 2023
LeeTwentyThree
approved these changes
May 24, 2023
There was a problem hiding this comment.
Works perfectly, thank you very much for this fix. Only issue I can find now is posted in #367.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
Changes made in this pull request
ConfigFileMetadata.HandleChoiceChangedto properly take anyChoiceChangedEventArgs<>type rather than a<T>which is defined at the class level elsewhereChoiceChangedEventArgssince the generic type paramShould resolve #316 if I'm understanding the issue correctly.
PLEASE TEST, I finished this at 1AM and need to sleep
Would appreciate feedback from @MrJumpscare