Add UploadHelper to assist in the uploading process #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UploadHelper/Program.cs
Outdated
| { | ||
| Console.WriteLine("Hm, why does it start with a V? Are you sure you meant to do that? If not, type R and we can retry that."); | ||
| var line = Console.ReadLine(); | ||
| if (line != null && line.ToLower() == "R") |
There was a problem hiding this comment.
line.ToLower() == “R” doesn’t seem quite right. Wouldn’t the uppercase R stop this condition from ever occurring?
There was a problem hiding this comment.
Nice catch I forgot that part of the code even existed
|
Not offering my own review, because @JKohlman had previously mentioned using github actions for this instead |
|
I will push this for now as I want to move forward with the project and make more prereleases with this simplified process, but GitHub Actions will definitely be preferable in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request