Fix compound tech patching #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 15, 2022 17:39
The patch previously set ALL compound techs to have the same dependencies as the most recently added one, this now properly sets the dependencies for each techtype individually
even purple didn't know why he used three loops for it
added back in code to change any existing compound tech dependencies, as I was unaware you could actually do that through smlhelper before
Metious
reviewed
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request
-fixed KnownTechPatcher from setting all CompoundTech dependencies to the most recently added ones
-added some comments, by request of Lee23 cause some of the syntax can be confusing
-reduced the code down to one foreach loop, rather than the previous three loops
-includes portions of old code commented out, I am hoping someone can test this further than I can and make sure it still works as intended, as this code does not seem to be necessary but it very well may be and I just haven't tested enough