Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic Icon Loading Fixes #277

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Automatic Icon Loading Fixes #277

merged 2 commits into from
Sep 14, 2022

Conversation

Metious
Copy link
Member

@Metious Metious commented Sep 14, 2022

Fix #273

Changes made in this pull request

  • Fixed automatic mod folder location targeting SMLHelper's folder rather than the mod in question's folder.

@Metious Metious linked an issue Sep 14, 2022 that may be closed by this pull request
Automatic icon loading for Spawnable doesn't work #273
Closed
PrimeSonic
PrimeSonic approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@PrimeSonic PrimeSonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Minor nitpick: since this is now a (get only) Property and not a Field anymore, the name should be capitalized.

That would cascade into more changes so I'm fine with this as a small fix.

@Metious Metious merged commit b5e8b3b into dev Sep 14, 2022
@Metious Metious deleted the IconLoading_Fixes branch September 14, 2022 14:41
@Metious Metious mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrimeSonic PrimeSonic PrimeSonic approved these changes

@MrPurple6411 MrPurple6411 Awaiting requested review from MrPurple6411

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic icon loading for Spawnable doesn't work
2 participants
@Metious @PrimeSonic