Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMLHelper 2.10.1 #230

Merged
merged 26 commits into from
Jul 6, 2021
Merged

SMLHelper 2.10.1 #230

merged 26 commits into from
Jul 6, 2021

Conversation

toebeann
Copy link
Contributor

@toebeann toebeann commented Jul 6, 2021

Changes made in this version

This is a backwards-compatible patch release.

  • Hotfix: Identified and resolved bugs in the CoordinatedSpawnsHandler implementation. If you were previously consuming the SpawnInfo API, pay close attention to this PR. Coordinated spawns hotfixes #229

Builds

Subnautica

Stable
Experimental

Below Zero

Stable
Experimental

Metious and others added 25 commits July 5, 2021 23:31
@Metious
Added Quaternion and Vector3 converters
43ec7e3
@Metious
added another null check
0497509
@Metious
added a JsonConstructor + custom Equality check
c619075
@Metious
overrode GetHashCode for C# to shut up
31321fa
@Metious
use the new converters
87498fa
@Metious
made the new converters public
ca7018a
@toebeann
Fix issue with the JsonConstructor implementation.
feeb60a 
The `rotation` is stored as a `Quaternion`, not as a `Vector3`.
@toebeann
Revert the added null conditional operator here, as it seems superf…
d5731a6 
…luous.
@toebeann
Prefer record over struct for the JSON data types.
e34713f
@toebeann
Prefer the generic form of JsonSerializer.Deserialize<T>
a294840
@toebeann
Fix property naming rule violations.
ec6fad8
@toebeann
Implement and exploit explicit cast operations between Quaternion<-…
7e16781 
…>`QuaternionJson` and `Vector3`<->`Vector3Json` for simpler code.
@toebeann
Implement a suitable GetHashCode() algorithm.
290ab6a
@toebeann
Added spawnPosition property to the Equality comparison as it appea…
68f455d 
…rs to have been missed in the initial implementation.
@toebeann
Version bump for hotfix build
eebee4e
@toebeann
Oculus.Newtonsoft.Json namespace is only applicable to the `SN.STAB…
10e489b 
…LE` branch.
@toebeann
Version bump for hotfix build
baa7a47
@toebeann
Slightly better-optimized GetHashCode implementation.
5555948
@toebeann
Implement IEquatable<SpawnInfo> rather than overriding `Equals(obje…
60dd1b6 
…ct)` and `GetHashCode()`
@toebeann
Simplified constructor overloads, prefer switch expressions over tern…
b110861 
…ary expressions.
@toebeann
Version bump for CoordinatedSpawnsHotfix build
7267bc4
@toebeann
Better techType comparison for determining spawnType.
96cdaa3
@toebeann
Redesigned SpawnInfo as a struct, so that value-based equality is…
ec77573 
… the expected default. Since the API was being redesigned, also took care of the fact the property names were violating property naming rules.
@toebeann
Version bump for hotfix build
b9802ce
@toebeann
Merge pull request #229 from Metious/CoordinatedSpawnsHotfix
670610d 
Coordinated spawns hotfixes
@toebeann toebeann self-assigned this Jul 6, 2021
PrimeSonic
PrimeSonic approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@PrimeSonic PrimeSonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@toebeann toebeann merged commit 1b11e4b into master Jul 6, 2021
@toebeann toebeann deleted the dev branch July 6, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrimeSonic PrimeSonic PrimeSonic approved these changes

@MrPurple6411 MrPurple6411 Awaiting requested review from MrPurple6411

Assignees

@toebeann toebeann

Labels
Priority: High Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toebeann @PrimeSonic @Metious