Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMLHelper 2.8.5 - Hotfix for FloatConverter globalisation issue. #188

Merged
merged 2 commits into from
Sep 10, 2020
Merged

SMLHelper 2.8.5 - Hotfix for FloatConverter globalisation issue. #188

merged 2 commits into from
Sep 10, 2020

Conversation

toebeann
Copy link
Contributor

Changes made in this pull request

  • Fixes a bug with FloatConverter not correctly reading JSON values from the invariant culture.
  • Improved error logging when failing to parse JSON.

@toebeann toebeann self-assigned this Sep 10, 2020
@toebeann toebeann merged commit 21122c2 into master Sep 10, 2020
@toebeann toebeann deleted the hotfix-floatconverter-globalisation-issue branch September 10, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrimeSonic PrimeSonic PrimeSonic approved these changes

@MrPurple6411 MrPurple6411 Awaiting requested review from MrPurple6411

@Alexejhero Alexejhero Awaiting requested review from Alexejhero

Assignees

@toebeann toebeann

Labels
Priority: Medium Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toebeann @PrimeSonic