-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Is this ready for review now? |
@Stuyk I will add some unit tests and I'm looking on minisearch package for the search engine. Do you agree to let me use this package instead of custom search engine ? |
@Tijawk I think it's fine to replace the search; the implementation I put in was enough for my needs. :) |
@Stuyk You can take a quick look on my PR. If it's ok, I will rebase commits to have a more readable git history and make it ready to final review |
ba46bbd
to
b473062
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had quite a few issues on my side; but after a little bit of work I did manage to get it working. Here's what I had to change to make it compatible.
I have no idea why but the Map type was just giving out tons of errors / issues.
Replacing with an Object seemed to have resolved all of it.
47daf20
to
ef3e4fd
Compare
- upgrade dependencies - update plugin options. - update types. - refactor builder to use VITEPRESS_CONFIG.pages - move search logic to useSimpleSearch to allow create custom Search.vue component - move styles in assets/simpleSearch.css - remove vue-tsc and add vite-plugin-dts to build .d.ts files - update README.md - add unit tests and github ci
ef3e4fd
to
019425f
Compare
I'm not sure we need pursue this offline search functionality any further after Vitepress finally added offline search with minisearch. You can see the merged PR here: vuejs/vitepress#2110 This repository is likely going to get archived after this. |
New options