Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Epochs to Address Unbonding Endpoint #744

Merged
merged 3 commits into from
May 25, 2023
Merged

Add Epochs to Address Unbonding Endpoint #744

merged 3 commits into from
May 25, 2023

Conversation

shellvish
Copy link
Contributor

Context and purpose of the change

This PR adds a new field to the address unbonding endpoint. In particular, this helps identify which epoch an unbonding started in. It's a relatively trivial addition of code.

Author's Checklist

I have...

  • [ X ] Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • [ X ] OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label May 13, 2023
@github-actions github-actions bot closed this May 19, 2023
@sampocs sampocs reopened this May 25, 2023
@sampocs sampocs changed the base branch from main to v9.1.0 May 25, 2023 19:22
@sampocs sampocs changed the base branch from v9.1.0 to main May 25, 2023 19:27
Copy link
Collaborator

@sampocs sampocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sampocs sampocs added the A:automerge Automatically merge PR once checks pass label May 25, 2023
@mergify mergify bot merged commit 0f8b0da into main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once checks pass C:CLI C:proto C:stakeibc Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants