Skip to content

Commit

Permalink
Remove nolint directives for interfacer. (cosmos#3839)
Browse files Browse the repository at this point in the history
  • Loading branch information
DimitrisJim authored Jun 14, 2023
1 parent 9ee95c9 commit 7ccabcb
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 40 deletions.
4 changes: 0 additions & 4 deletions modules/apps/transfer/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ import (
var _ sdk.Msg = (*MsgUpdateParams)(nil)

// NewMsgUpdateParams creates a new MsgUpdateParams instance
//
//nolint:interfacer
func NewMsgUpdateParams(authority string, params Params) *MsgUpdateParams {
return &MsgUpdateParams{
Authority: authority,
Expand Down Expand Up @@ -44,8 +42,6 @@ func (msg MsgUpdateParams) GetSigners() []sdk.AccAddress {
}

// NewMsgTransfer creates a new MsgTransfer instance
//
//nolint:interfacer
func NewMsgTransfer(
sourcePort, sourceChannel string,
token sdk.Coin, sender, receiver string,
Expand Down
8 changes: 0 additions & 8 deletions modules/core/02-client/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ var (
)

// NewMsgCreateClient creates a new MsgCreateClient instance
//
//nolint:interfacer
func NewMsgCreateClient(
clientState exported.ClientState, consensusState exported.ConsensusState, signer string,
) (*MsgCreateClient, error) {
Expand Down Expand Up @@ -94,8 +92,6 @@ func (msg MsgCreateClient) UnpackInterfaces(unpacker codectypes.AnyUnpacker) err
}

// NewMsgUpdateClient creates a new MsgUpdateClient instance
//
//nolint:interfacer
func NewMsgUpdateClient(id string, clientMsg exported.ClientMessage, signer string) (*MsgUpdateClient, error) {
anyClientMsg, err := PackClientMessage(clientMsg)
if err != nil {
Expand Down Expand Up @@ -141,8 +137,6 @@ func (msg MsgUpdateClient) UnpackInterfaces(unpacker codectypes.AnyUnpacker) err
}

// NewMsgUpgradeClient creates a new MsgUpgradeClient instance
//
//nolint:interfacer
func NewMsgUpgradeClient(clientID string, clientState exported.ClientState, consState exported.ConsensusState,
proofUpgradeClient, proofUpgradeConsState []byte, signer string,
) (*MsgUpgradeClient, error) {
Expand Down Expand Up @@ -219,8 +213,6 @@ func (msg MsgUpgradeClient) UnpackInterfaces(unpacker codectypes.AnyUnpacker) er
}

// NewMsgSubmitMisbehaviour creates a new MsgSubmitMisbehaviour instance.
//
//nolint:interfacer
func NewMsgSubmitMisbehaviour(clientID string, misbehaviour exported.ClientMessage, signer string) (*MsgSubmitMisbehaviour, error) {
anyMisbehaviour, err := PackClientMessage(misbehaviour)
if err != nil {
Expand Down
8 changes: 0 additions & 8 deletions modules/core/03-connection/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ var (

// NewMsgConnectionOpenInit creates a new MsgConnectionOpenInit instance. It sets the
// counterparty connection identifier to be empty.
//
//nolint:interfacer
func NewMsgConnectionOpenInit(
clientID, counterpartyClientID string,
counterpartyPrefix commitmenttypes.MerklePrefix,
Expand Down Expand Up @@ -79,8 +77,6 @@ func (msg MsgConnectionOpenInit) GetSigners() []sdk.AccAddress {
}

// NewMsgConnectionOpenTry creates a new MsgConnectionOpenTry instance
//
//nolint:interfacer
func NewMsgConnectionOpenTry(
clientID, counterpartyConnectionID, counterpartyClientID string,
counterpartyClient exported.ClientState,
Expand Down Expand Up @@ -174,8 +170,6 @@ func (msg MsgConnectionOpenTry) GetSigners() []sdk.AccAddress {
}

// NewMsgConnectionOpenAck creates a new MsgConnectionOpenAck instance
//
//nolint:interfacer
func NewMsgConnectionOpenAck(
connectionID, counterpartyConnectionID string, counterpartyClient exported.ClientState,
proofTry, proofClient, proofConsensus []byte,
Expand Down Expand Up @@ -253,8 +247,6 @@ func (msg MsgConnectionOpenAck) GetSigners() []sdk.AccAddress {
}

// NewMsgConnectionOpenConfirm creates a new MsgConnectionOpenConfirm instance
//
//nolint:interfacer
func NewMsgConnectionOpenConfirm(
connectionID string, proofAck []byte, proofHeight clienttypes.Height,
signer string,
Expand Down
20 changes: 0 additions & 20 deletions modules/core/04-channel/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ var (

// NewMsgChannelOpenInit creates a new MsgChannelOpenInit. It sets the counterparty channel
// identifier to be empty.
//
//nolint:interfacer
func NewMsgChannelOpenInit(
portID, version string, channelOrder Order, connectionHops []string,
counterpartyPortID string, signer string,
Expand Down Expand Up @@ -74,8 +72,6 @@ func (msg MsgChannelOpenInit) GetSigners() []sdk.AccAddress {
// NewMsgChannelOpenTry creates a new MsgChannelOpenTry instance
// The version string is deprecated and will be ignored by core IBC.
// It is left as an argument for go API backwards compatibility.
//
//nolint:interfacer
func NewMsgChannelOpenTry(
portID, version string, channelOrder Order, connectionHops []string,
counterpartyPortID, counterpartyChannelID, counterpartyVersion string,
Expand Down Expand Up @@ -132,8 +128,6 @@ func (msg MsgChannelOpenTry) GetSigners() []sdk.AccAddress {
}

// NewMsgChannelOpenAck creates a new MsgChannelOpenAck instance
//
//nolint:interfacer
func NewMsgChannelOpenAck(
portID, channelID, counterpartyChannelID string, cpv string, proofTry []byte, proofHeight clienttypes.Height,
signer string,
Expand Down Expand Up @@ -180,8 +174,6 @@ func (msg MsgChannelOpenAck) GetSigners() []sdk.AccAddress {
}

// NewMsgChannelOpenConfirm creates a new MsgChannelOpenConfirm instance
//
//nolint:interfacer
func NewMsgChannelOpenConfirm(
portID, channelID string, proofAck []byte, proofHeight clienttypes.Height,
signer string,
Expand Down Expand Up @@ -223,8 +215,6 @@ func (msg MsgChannelOpenConfirm) GetSigners() []sdk.AccAddress {
}

// NewMsgChannelCloseInit creates a new MsgChannelCloseInit instance
//
//nolint:interfacer
func NewMsgChannelCloseInit(
portID string, channelID string, signer string,
) *MsgChannelCloseInit {
Expand Down Expand Up @@ -260,8 +250,6 @@ func (msg MsgChannelCloseInit) GetSigners() []sdk.AccAddress {
}

// NewMsgChannelCloseConfirm creates a new MsgChannelCloseConfirm instance
//
//nolint:interfacer
func NewMsgChannelCloseConfirm(
portID, channelID string, proofInit []byte, proofHeight clienttypes.Height,
signer string,
Expand Down Expand Up @@ -303,8 +291,6 @@ func (msg MsgChannelCloseConfirm) GetSigners() []sdk.AccAddress {
}

// NewMsgRecvPacket constructs new MsgRecvPacket
//
//nolint:interfacer
func NewMsgRecvPacket(
packet Packet, proofCommitment []byte, proofHeight clienttypes.Height,
signer string,
Expand Down Expand Up @@ -346,8 +332,6 @@ func (msg MsgRecvPacket) GetSigners() []sdk.AccAddress {
}

// NewMsgTimeout constructs new MsgTimeout
//
//nolint:interfacer
func NewMsgTimeout(
packet Packet, nextSequenceRecv uint64, proofUnreceived []byte,
proofHeight clienttypes.Height, signer string,
Expand Down Expand Up @@ -386,8 +370,6 @@ func (msg MsgTimeout) GetSigners() []sdk.AccAddress {
}

// NewMsgTimeoutOnClose constructs new MsgTimeoutOnClose
//
//nolint:interfacer
func NewMsgTimeoutOnClose(
packet Packet, nextSequenceRecv uint64,
proofUnreceived, proofClose []byte,
Expand Down Expand Up @@ -431,8 +413,6 @@ func (msg MsgTimeoutOnClose) GetSigners() []sdk.AccAddress {
}

// NewMsgAcknowledgement constructs a new MsgAcknowledgement
//
//nolint:interfacer
func NewMsgAcknowledgement(
packet Packet,
ack, proofAcked []byte,
Expand Down

0 comments on commit 7ccabcb

Please sign in to comment.