Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rework public API #516

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: Rework public API #516

merged 1 commit into from
Sep 17, 2024

Conversation

Stranger6667
Copy link
Owner

No description provided.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 92.41071% with 17 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (d8eb69d) to head (2e1d3d7).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema-py/src/lib.rs 0.00% 9 Missing ⚠️
crates/jsonschema/src/compilation/options.rs 77.27% 5 Missing ⚠️
crates/jsonschema-cli/src/main.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   85.01%   85.09%   +0.07%     
==========================================
  Files          69       69              
  Lines       10504    10566      +62     
==========================================
+ Hits         8930     8991      +61     
- Misses       1574     1575       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 16, 2024

CodSpeed Performance Report

Merging #516 will improve performances by 15.16%

Comparing dd/constructors (2e1d3d7) with master (c02e55d)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark master dd/constructors Change
Fast/Invalid[is_valid] 886.1 ns 769.4 ns +15.16%

@Stranger6667 Stranger6667 force-pushed the dd/constructors branch 5 times, most recently from d0e63c0 to 2e1d3d7 Compare September 17, 2024 20:43
Signed-off-by: Dmitry Dygalo <[email protected]>
@Stranger6667 Stranger6667 marked this pull request as ready for review September 17, 2024 20:46
@Stranger6667 Stranger6667 merged commit 21f6ee5 into master Sep 17, 2024
30 checks passed
@Stranger6667 Stranger6667 deleted the dd/constructors branch September 17, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant