Don't overwrite system/command line CMAKE_CXX_FLAGS #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather, append the additional flags required by the project. This will allow system-supplied flags to be used, as well as enable the `--cmake-args` option for colcon to supply flags.
SteveMacenski
approved these changes
Jul 29, 2020
|
Just wanting on CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Rather than overwriting the
CMAKE_CXX_FLAGSthat may have been supplied by the system, environment, or command line arguments, append the additional flags required by the project. This will allow system-supplied flags to be used, as well as enable the--cmake-argsoption for colcon to supply flags.Description of documentation updates required from your changes
(none)
Future work that may be required in bullet points
(none)