Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using supplied decoder for encrypted values #23

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Aug 9, 2024

Fix using supplied decoder for encrypted values

♻️ Current situation & Problem

There was an issue in the read implementation where the supplied decoder was only used if the element wasn't encrypted. The other code path was forgotten to be updated in #21.
This issue is fixed by this PR.

⚙️ Release Notes

  • Fixed an issue where the supplied decoder wasn't used.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (52bd5cb) to head (f58863b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files           6        6           
  Lines         453      453           
=======================================
  Hits          417      417           
  Misses         36       36           
Files Coverage Δ
Sources/SpeziLocalStorage/LocalStorage.swift 89.43% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52bd5cb...f58863b. Read the comment docs.

@Supereg Supereg merged commit 099e059 into main Aug 9, 2024
18 checks passed
@Supereg Supereg deleted the fix/json-decoder-encrypted branch August 9, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant