Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Strict Concurrency #27

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Support Strict Concurrency #27

merged 2 commits into from
Aug 13, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Aug 11, 2024

Support Strict Concurrency

♻️ Current situation & Problem

This PR adds compatibility with Swift 6. Only minor changes were required.

⚙️ Release Notes

  • Compatibility with Swift 6.

📚 Documentation

We improved some of the documentations reducing the amount of links within the brief documentation line.

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg; looks great!

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Aug 12, 2024
@PSchmiedmayer PSchmiedmayer linked an issue Aug 12, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (f0e815e) to head (735d13f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   78.69%   78.69%           
=======================================
  Files           4        4           
  Lines         319      319           
=======================================
  Hits          251      251           
  Misses         68       68           
Files Coverage Δ
...urces/SpeziContact/Contact Views/ContactView.swift 78.14% <ø> (ø)
...rces/SpeziContact/Contact Views/ContactsList.swift 52.00% <ø> (ø)
Sources/SpeziContact/Models/Contact.swift 100.00% <ø> (ø)
Sources/SpeziContact/Models/ContactOption.swift 86.96% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0e815e...735d13f. Read the comment docs.

@Supereg Supereg merged commit 9a7aa7e into main Aug 13, 2024
7 checks passed
@Supereg Supereg deleted the feature/strict-concurrency branch August 13, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Complete Concurrency Checking
2 participants