Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backward compatibility to secret masking for output schema #5783

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Add backward compatibility to secret masking for output schema #5783

merged 6 commits into from
Oct 26, 2022

Conversation

m4dcoder
Copy link
Contributor

@m4dcoder m4dcoder commented Oct 23, 2022 •
edited
Loading

Add backward compatibility to secret masking introduced in #5319 to prevent security-relative issues. Migration to the new schema is required to take advantage of the full output schema validation.

@m4dcoder
Add backward compatibility to secret masking for legacy output schema
3e1dbe1 
A new output schema using full JSON schema was introduced and secrets
previously masked using the legacy output schema now being displayed as
plain text. To prevent security relative issues, add backward
compatibility to secret masking. Full output schema validattion will
need to be migrated to the new schema.
@m4dcoder
Add changelog entry
316a036
@m4dcoder
Fix minor typo in changelog entry
856ad86
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Oct 23, 2022
cognifloyd
cognifloyd reviewed Oct 23, 2022
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adjust the name of the test (legacy is no longer "noop") and clean up the comment that says nothing will be masked?

arm4b
arm4b reviewed Oct 24, 2022
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@arm4b arm4b added this to the 3.8.0 milestone Oct 24, 2022
@m4dcoder
Copy link
Contributor Author

ok. I'll update the changelog and description here.

@m4dcoder m4dcoder changed the title Add backward compatibility to secret masking for legacy output schema Add backward compatibility to secret masking for prev version of output schema Oct 26, 2022
@m4dcoder m4dcoder changed the title Add backward compatibility to secret masking for prev version of output schema Add backward compatibility to secret masking for prev ver of output schema Oct 26, 2022
@m4dcoder m4dcoder changed the title Add backward compatibility to secret masking for prev ver of output schema Add backward compatibility to secret masking for output schema Oct 26, 2022
cognifloyd
cognifloyd approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned up the test name.

arm4b
arm4b approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@cognifloyd cognifloyd merged commit 2b4e359 into master Oct 26, 2022
@cognifloyd cognifloyd deleted the fix-output-secret-masking branch October 26, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

@cognifloyd cognifloyd cognifloyd approved these changes

Assignees
No one assigned
Labels
size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@m4dcoder @arm4b @cognifloyd