Throw a more user-friendly error on permission denied when trying to to write a pack data file #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
write pack action file.
when we create a pack sub-directory.
copies over to /opt/stackstorm/packs.
|
And the actual root cause for that error was fixed in this commit - 1342f74 ( I will cherry pick this into v3.0 branch once it's approved. |
Kami
commented
Apr 24, 2019
| @@ -290,7 +290,7 @@ def apply_pack_owner_group(pack_path): | |||
|
|
|||
| def apply_pack_permissions(pack_path): | |||
| """ | |||
| Recursively apply permission 770 to pack and its contents. | |||
| Recursively apply permission 775 to pack and its contents. | |||
There was a problem hiding this comment.
This docstring was incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a small issue I identified while testing latest st2flow packages.
Right now if pack permissions are not configured correctly and st2api doesn't have permission to write to the pack directory / sub-directory, Internal Server Error bubbles up all the way to st2flow.
This pull request fixes so we now throw a more user-friendly (non internal server error) error message.
From st2api.log: