Fix kombu release version #4485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kami
approved these changes
Jan 2, 2019
arm4b
reviewed
Jan 2, 2019
| @@ -5,7 +5,7 @@ greenlet==0.4.15 | |||
| # depend on rely | |||
| eventlet==0.24.1 | |||
| gunicorn==19.9.0 | |||
| kombu==4.2.2 | |||
| kombu==4.2.2.post1 | |||
There was a problem hiding this comment.
Yeah, it's part of a Python versioning standard - https://www.python.org/dev/peps/pep-0440/#post-releases
I'm fine with it since it's considered a "final" and not a dev / beta release. But yeah, I would definitely prefer them to actually bump a version to 4.2.3 or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kombu team had a release issue, and accidentally published the wrong code as 4.2.2 to PyPi. They have fixed this, and pulled 4.2.2.
celery/kombu#966