Support --register-fail-on-failure in st2ctl #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--register-fail-on-failure` option that I [learned about yesterday|https://stackstorm-community.slack.com/archives/community/p1465382685000395] is pretty useful. We should expose this option through `st2ctl reload`. Our content management story currently deploys packs with ansible and triggers `st2ctl reload --register-all` (and in some playbooks `--register-setup-virtualenvs` as well). So right now it fails silently if the content can't be loaded. Would be nice if we could just pass this flag through directly so it returns the error to ansible to display. Or you can say, no, just use the `st2-register-content` script directly for more flags. That's fine too. :)
|
Thanks - I agree that this functionality is useful. Please make sure to also update st2ctl in st2common/bin/ directory. |
|
lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--register-fail-on-failureoption that I [learned about yesterday|https://stackstorm-community.slack.com/archives/community/p1465382685000395] is pretty useful. We should expose this option throughst2ctl reload.Our content management story currently deploys packs with ansible and triggers
st2ctl reload --register-all(and in some playbooks--register-setup-virtualenvsas well). So right now it fails silently if the content can't be loaded. Would be nice if we could just pass this flag through directly so it returns the error to ansible to display.Or you can say, no, just use the
st2-register-contentscript directly for more flags. That's fine too. :)