Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix st2ctl to handle upstart #2551

Merged
merged 1 commit into from
Mar 3, 2016

Conversation

dennybaa
Copy link
Contributor

@dennybaa dennybaa commented Mar 2, 2016

No description provided.

@Kami
Copy link
Member

Kami commented Mar 2, 2016

LGTM, but I haven't tested it yet.

We also need some tests for that, I believe this would tie into tests @lakshmi-kannan is working on.

@dennybaa
Copy link
Contributor Author

dennybaa commented Mar 2, 2016

@Kami do we?
https://github.com/StackStorm/st2-packages/blob/master/packages/st2/bin/runners.sh#L17-L22
it's been tested many times when we use packages. and every time we invoke start wrapper actionrunner service.

@Kami
Copy link
Member

Kami commented Mar 2, 2016

Yeah, i do think tests would be good - and they need to cover all the service managers we support.

In any case, that's not a blocker for now, but when @lakshmi-kannan comes up with a framework for package tests, we should add those test cases there.

@dennybaa
Copy link
Contributor Author

dennybaa commented Mar 2, 2016

@dennybaa
Copy link
Contributor Author

dennybaa commented Mar 2, 2016

yup not now/

@dennybaa
Copy link
Contributor Author

dennybaa commented Mar 2, 2016

@Kami there's actually nothing really to come up with package tests should be serverspec/rspec. It's the most easiest and appropriate framework which is available (on the it market as i'm aware) for this need.
However they should not be as bad as the current tests in st2-packages. I still see no time and no necessity to refactor them from zero.
Also it's desirable to remove all rake build code from st2-packages, it's complexity and the whole existence were defined by wrong task input --- we want to build packages per component.

dennybaa added a commit that referenced this pull request Mar 3, 2016
@dennybaa dennybaa merged commit 4294bda into StackStorm:master Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants