Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add issue and pull request templates #31

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Conversation

selbekk
Copy link
Contributor

@selbekk selbekk commented Feb 27, 2018

This pull request adds an issue template that asks some basic questions that will help the user write a descriptive issue.

I'm open for discussing the contents - but I think this is one of those things we improve by using it a lot.

Fixes #9

@selbekk
Copy link
Contributor Author

selbekk commented Feb 27, 2018

Not sure if we need a pull request template as well?

antidecaf
antidecaf previously approved these changes Feb 27, 2018
wkillerud
wkillerud previously approved these changes Feb 27, 2018
Copy link
Contributor

@wkillerud wkillerud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start :) It may seem odd if filing a question, but we'll work it out as we go.

@selbekk
Copy link
Contributor Author

selbekk commented Feb 27, 2018

Not sure how we would deal with usage questions. I can add a comment about wiping the template if you have a question.

This commit adds an issue template that asks some basic questions
that will help the user write a descriptive issue.
@selbekk selbekk dismissed stale reviews from wkillerud and antidecaf via 0de0938 February 27, 2018 16:54
@selbekk selbekk changed the title docs: Add issue template docs: Add issue template and pull request template Feb 27, 2018
@selbekk selbekk changed the title docs: Add issue template and pull request template docs: Add issue and pull request templates Feb 27, 2018
@selbekk
Copy link
Contributor Author

selbekk commented Feb 27, 2018

I added a pull request template as well. It's not really a template as much as it's a reminder to adhere to CONTRIBUTING.md guidelines.

wkillerud
wkillerud previously approved these changes Feb 28, 2018
Before submitting a pull request, please have a look through the CONTRIBUTING.md
document. TL;DR:

- Write proper commit messages tagged with the correct package and scope
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention conventional commits specifically here, perhaps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Do you have a suggestion as to how it should be worded?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write proper commit messages tagged with the correct package and scope. We follow the Conventional Commits convention.

... or some such. :)

antidecaf
antidecaf previously approved these changes Feb 28, 2018
This commit adds a pull request template, reminding contributors to
adhere to our code of conduct and contribution guidelines.
@selbekk selbekk merged commit 6922238 into master Feb 28, 2018
@selbekk selbekk deleted the 9-add-issue-template branch February 28, 2018 10:12
@selbekk
Copy link
Contributor Author

selbekk commented Feb 28, 2018

@antidecaf ended up with something similar. Unfortunately, this is unparsed markdown, so you can't really have links. Hopefully this will be good enough - at least for a start :)

kwltrs pushed a commit that referenced this pull request Mar 7, 2018
docs: Add issue and pull request templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants